[MRG] Adding picklist arg to sourmash_args.load_picklist to allow the option
#3839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3839 +/- ##
===========================================
- Coverage 88.15% 48.12% -40.04%
===========================================
Files 137 137
Lines 22610 22614 +4
Branches 2303 2305 +2
===========================================
- Hits 19931 10882 -9049
- Misses 2366 11532 +9166
+ Partials 313 200 -113
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
This update was necessary to build the tests here sourmash-bio/sourmash_utils#8 And for sourmash plugin support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3838
This PR allows for the entire namespace to be used with the sourmash_args.load_picklist function as well as a correctly formatted picklist string.
i.e
This will be used in conjunction with #3837 in pangenomics scripts
Ref:
https://stackoverflow.com/questions/34869889/what-is-the-proper-way-to-determine-if-an-object-is-a-bytes-like-object-in-pytho
https://realpython.com/ref/builtin-functions/isinstance/